Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2.21.0 #1375

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Release/2.21.0 #1375

wants to merge 10 commits into from

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 86de72e
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6736c8696009130008d93e38

@cypress Cypress
Copy link

cypress bot commented Nov 12, 2024 •
edited
Loading

ripple-framework    Run #2389

Run Properties:  status check passed Passed #2389  •  git commit 86de72e7ba: Merge pull request #1379 from dpc-sdp/bugfix/layer-search
Project ripple-framework
Branch Review release/2.21.0
Run status status check passed Passed #2389
Run duration 09m 17s
Commit git commit 86de72e7ba: Merge pull request #1379 from dpc-sdp/bugfix/layer-search
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @waitingallday