Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/317 #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

XIELongDragon
Copy link
Contributor

uint64 cast to int64 caused lost of data #317

@XIELongDragon XIELongDragon force-pushed the bugfix/317 branch 3 times, most recently from 94f66bf to 28cea5a Compare December 20, 2021 00:01
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #318 (21e069a) into master (31d438d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   96.90%   96.91%           
=======================================
  Files          62       62           
  Lines        3488     3498   +10     
=======================================
+ Hits         3380     3390   +10     
  Misses         92       92           
  Partials       16       16           
Flag Coverage Δ
unittests 96.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d438d...21e069a. Read the comment docs.

@Hackfred
Copy link

Any plans to merge this? :)
Would be nice to have it in a future release (currently I have to do some pretty nasty workarounds to not run into this). Or is there any way how I can support to get it merged? :)

@XIELongDragon
Copy link
Contributor Author

Hi @Hackfred , as @mattn and @doug-martin did not come for a long time. Maybe you can use my fork before this PR is merged.

add the below line before the require ( line in your go.mod file,

replace github.com/doug-martin/goqu/v9 v9.18.0 => github.com/XIELongDragon/goqu/v9 v9.18.1

you may need to update the goqu version v9.18.0 to the version you used.

@XIELongDragon
Copy link
Contributor Author

@mattn @Frug can you help to take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants