Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 11 Theming Changes #8870
Windows 11 Theming Changes #8870
Changes from 237 commits
43ef4227c1ba0a97503f8ade8d8016e227a5c56fa1928ef7edd3150d50327da1b9551efcd59a692e875d3752963c88e357229513a09d7bf07cc5d2f4ecfd2720511e973e9631c5bca65b953dcc354b4bf09a677381c949407d927ac2c580aeaeeb689d1c01ee63c1cdc06683c7e4693045390288e4fd3d9c3505d239a5cf20c812f1e363e7beae99c989bbf8135e3b513a597c598a981faf47252a37acf1ef9bb7d6ff40323be027ff1ae8ccac06098c438a3e560594eb347a6be77ee428bb7fe430cf3f748b70e3e2fb9f09ffe67e9e7d310b626fb31e71872c6df32cffb2e547cc75c24c9cdd0759d4741dbf0f067921104ff61d317de448a691d68e89ddc81dded1e17d63d9b514fa83084777dcd13c8f62799b4447ea65dfd9986c1bd22db8ff59172107bb22bd5769e53dbda863260dd7c5684b3e25612bb67f68068dc896473696434f9ab8e9e3634c3cd9a96783698b4fe721c9baa69d2b573992bf94ba42800fcf4b940449de6b4a60efc2b2a622007a9c4994cb0b453284e77cb0c2d3be439c031911515e5722ed9012daf16317fad9a30ab93e3e8f0b850d4ccb7a2e31e9c148595112c7c234f2d20f9d82b9031321dd9a5777fb21bb133567e563527c2eac7df285710aa8dd0c2a6bcf29fefd655a619628dd08f70a76acd65e6f34a0fd3fefe77304d4dc440e0d309acde510a6ed34d7cf30018c329d3064641eed31721f2cdf546df32f9c1ee9982adfc37fccb6d2109740d3e0ec202575442b28d66891dae6830674d1a9e9ff7c82b79ace9bcb53fea17507be1d32ba9b60e31b136f5a4dc5ba357c65880360ba33b3fda1ca220cd8cf1ef9e555ae8e37d9cca7bf57add7510c719ec3f035c94f9915a1d01761170f1b8aa9d174eee773be05672d99588b29b60dfe8dceb5a0c5e7c4b263cc1e0cd23975815ce9ad36152df8d411d535d0d0155271ccaab9ddc12fd060c0a52f8fbdfee86f04eba8fa1f44763f1bce059c156f2d126174f82c6594a325f75e2f0a09e5c5fae66a29664bf0e3a97835cf9a116f1f45ccd28c95efeb7966251c72abc5cafc2e0851dbd9da1600fe25b70db299bef0026503a5c6f209f9e17f516aa1c92a640a235712b6e43e4132964db3798fe505ad766f8bf121d0aec0867df1832f689d9f148b3030b569454d053209b085f316ca5d6d850c1cef1dbffb693a09dd78a9f06f1a6fb13ae58a1e8459cdb7a943afed3410File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling this "Fluent Windows" as the theme name is a divergence from WinUI I think. "Windows" also seems unnecessary as WPF only runs on Windows Desktop anyway (the Microsoft version).
Fluent v1: Windows 10 (which probably should have been included some time ago separately https://github.com/Kinnara/ModernWpf)
Fluent v2: Windows 11 and what this theme is based on.
The name for this theme should be "Fluent2" which has precedent: Aero2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft Using "Fluent" is definitely better now. However, I'm curious why you didn't go with the technically correct name "Fluent2"?
If there is ever a "Fluent3" variation there might be a problem as you are faced with:
-> Using Fluent2 name in WPF for WinUI's Fluent3 (off by one is confusing)
-> Just updating Fluent to the latest and don't worry about the name (is breaking for apps depending on how much the styles change so is frowned upon)
-> Renaming this theme to Fluent2 and then have a side-by-side Fluent3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that Windows is redundant here. We have changed the name to Fluent now. As we don't already have a Fluent version, Fluent2 may create confusion. We are still discussing the API proposal for Theme switching, where we will be discussing the names and we can rediscuss it with the API proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft Ok, thanks for the clarification. Skipping just "Fluent" may indeed raise some questions to users.
Also note that it would theoretically be possible for a community member to contribute a Fluent (version 1) in the future (but not sure if you would allow resources for that as it's obsolete). So that would be a naming collision in that case. Just another thought here.