Add ability to select a document's project context #7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
reviewed
Jul 11, 2024
| @@ -161,8 +161,12 @@ | |||
| "Fix All: ": "Fix All: ", | |||
| "C# Workspace Status": "C# Workspace Status", | |||
| "Open solution": "Open solution", | |||
| "Select context": "Select context", | |||
| "C# Project Context Status": "C# Project Context Status", | |||
| "Active File Context": "Active File Context", | |||
There was a problem hiding this comment.
Wondering - could we merge this into the select button?
e.g.
ProjectA (net6.0) Change Active File Context
or maybe we could even put the document name in it?
ProjectA (net6.0) Change Program.cs Context
There was a problem hiding this comment.
Sure, although the select command is only visible when there are multiple project contexts. Would it be jarring for the text to move from the item details to the command and back again as you navigate?
There was a problem hiding this comment.
ah hmm. I wonder if we should just always show the button even if there's only one. Not sure
JoeRobich
force-pushed
the
dev/jorobich/select-project-context
branch
2 times, most recently
from
6ca46de to
44b576a
Compare
- Adds select project context commands - Adds the select command to the Project Context status item - Updates middleware to send selected context with server requests.
JoeRobich
force-pushed
the
dev/jorobich/select-project-context
branch
from
44b576a to
ee62554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #7321 and adds the ability to select a document's project context.
Select.Project.Context.mp4
TODO: