Adding changes to support use monovsdbg to debug wasm apps. #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/shared/utils.ts
Outdated
| @@ -43,6 +43,14 @@ export function isWebProject(projectPath: string): boolean { | |||
| return projectFileText.toLowerCase().indexOf('sdk="microsoft.net.sdk.web"') >= 0; | |||
| } | |||
|
|
|||
| export function isWebAssemblyProject(projectPath: string): boolean { | |||
| const projectFileText = fs.readFileSync(projectPath, 'utf8'); | |||
…_ASSEMBLIES to enable hotreload.
…/vscode-csharp into dev/thays/support_wasm_monovsdbg
|
@gregg-miskelly can you please review again? |
gregg-miskelly
requested changes
Jun 28, 2024
|
@gregg-miskelly I think I'm done again. If you can review it will be great. |
gregg-miskelly
approved these changes
Jul 11, 2024
|
Did you want to update a case for the updatePackageDependencies script? |
I'm using npm run updatePackageDependencies to update the webassembly package but I didn't need to change this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding changes to support debug wasm apps using monovsdbg.
Tested scenarios with the new setting enabled and this PR:
With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
Tested scenarios only updating C# DevKit with the monovsdbg support:
Tested scenarios with this PR and C# DevKit without the monovsdbg support:
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - DISABLED