Use the new unified Trie and add support for look-arounds #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlorbetske
force-pushed
the
dev/mlorbe/AddSpikesForCommandParserAndNewTrie
branch
from
5c7ad9e to
c367ed0
Compare
|
Remaining work:
|
mlorbetske
force-pushed
the
dev/mlorbe/AddSpikesForCommandParserAndNewTrie
branch
from
bfcd99a to
ecb036a
Compare
mlorbetske
changed the title
|
We'll make a new issue for adding full support for lookarounds for each operation (in its matched tokens). This PR is now ready. |
9 tasks
seancpeters
reviewed
Mar 14, 2017
| { | ||
| byte[] tmp = new byte[_trie.MaxLength]; | ||
| byte[] tmp = new byte[_trie.MaxLength + 1]; |
There was a problem hiding this comment.
The sizedToStrream check was removed with this PR. Wondering if there could be problems if the entire source stream is shorter than the _trie.MaxLength + 1.
There was a problem hiding this comment.
This is OK as the current buffer size is tracked differently
seancpeters
reviewed
Mar 14, 2017
|
|
||
| if (CurrentBufferLength == CurrentBuffer.Length && CurrentBufferLength - CurrentBufferPosition < _trie.MaxLength) | ||
| //Loop until we run out of data in the buffer | ||
| for(; CurrentBufferPosition < CurrentBufferLength;) |
seancpeters
reviewed
Mar 14, 2017
| namespace Microsoft.TemplateEngine.Core.Matching | ||
| { | ||
| public abstract class TerminalBase | ||
| { |
seancpeters
reviewed
Mar 14, 2017
| } | ||
|
|
||
| public bool GetOperation(byte[] buffer, int bufferLength, ref int currentBufferPosition, out int token) | ||
| public void AddToken(IToken token, int index) | ||
| { |
There was a problem hiding this comment.
I don't see any checking that multiple tokens don't have the same index. This would only potentially be a problem if tokens are added with explicit indexes.
OTOH, I don't have this fully internalized yet, so perhaps duplicated indexes are ok.
seancpeters
approved these changes
Mar 14, 2017
…port seeking when doing sizing to streams, convert for with no initial condition or iteration action to a while loop
…s://github.com/mlorbetske/templating into dev/mlorbe/AddSpikesForCommandParserAndNewTrie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge - these are only here for visibility for now
This PR contains two things:
dotnetcommands that will need to be dealt with separately)@seancpeters