Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling configuring IP Address for Dotnet Backend #537

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Enabling configuring IP Address for Dotnet Backend #537

wants to merge 18 commits into from

Conversation

Niharikadutta
Copy link
Collaborator

@Niharikadutta Niharikadutta commented Jun 5, 2020 •
edited

This PR gives the user the ability to specify a particular IP address they want the Dotnet backend process to spin up on while submitting the .NET for Apache Spark application.

The user can do that by setting the following environment variables:

  1. For the IP address they want to spin DotnetBackend on - DOTNET_SPARK_BACKEND_IP_ADDRESS
  2. For the IP address they want to run the .NET for Spark Application on - DOTNET_SPARK_CALLBACK_SERVER_IP_ADDRESS

This PR fixes #419

@Niharikadutta Niharikadutta changed the title [WIP] Enabling configuring IP Address for Dotnet Backend Enabling configuring IP Address for Dotnet Backend Jun 11, 2020
@imback82
Copy link
Contributor

// if not added, default islocalhost`

Can we not update the usage, but let the user set the environment variable?

@imback82
Copy link
Contributor

@suhsteve Can you help reviewing this PR?

@imback82 imback82 added the enhancement New feature or request label Jun 12, 2020
@imback82 imback82 mentioned this pull request Jun 12, 2020
Open
@Niharikadutta Niharikadutta mentioned this pull request Jun 18, 2020
Closed
Base automatically changed from master to main March 18, 2021 16:48
@laskli
Copy link

laskli commented Mar 4, 2022

@Niharikadutta Any updates on this one? We are having trouble debugging our .Net for Spark application with docker container setup and this seems to fix the issue.

@Macromullet
Copy link
Contributor

Can we get an update on this PR @Niharikadutta? What are the security concerns @imback82 ? If it's user-configurable and defaults to the most secure, how is that any different than an ASP.NET server allowing 0.0.0.0 when specified explicitly by the user. The general guidance for WSL2 is to run Linux based things you want to connect to with 0.0.0.0. We wouldn't be doing the override in anything other than a debug/test scenario, so it would be secure by default.

@Niharikadutta
Copy link
Collaborator Author

@Macromullet , @ZavezX we are working on getting this PR merged asap, thank you for your patience.

@Niharikadutta
Copy link
Collaborator Author

Niharikadutta commented Apr 5, 2022 •
edited

@suhsteve, @elvaliuliuliu Could you please help review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macromullet Macromullet Macromullet requested changes

@suhsteve suhsteve Awaiting requested review from suhsteve

@imback82 imback82 Awaiting requested review from imback82

At least 2 approving reviews are required to merge this pull request.

Assignees

@Niharikadutta Niharikadutta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Dotnet Backend IPAddress
5 participants
@Niharikadutta @imback82 @laskli @Macromullet @suhsteve