-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Move ComWrappers AddRef to C/C++ #110815
Open
github-actions
wants to merge
8
commits into
release/9.0-staging
Choose a base branch
from
backport/pr-110762-to-release/9.0-staging
base: release/9.0-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[release/9.0-staging] Move ComWrappers AddRef to C/C++ #110815
github-actions
wants to merge
8
commits into
release/9.0-staging
from
backport/pr-110762-to-release/9.0-staging
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaml invokes AddRef while holding a lock that it *also* holds while a GC is in progress. Managed AddRef had to synchronize with the GC that caused intermittent deadlocks with the other thread holding Xaml's lock. This change reverts the managed AddRef implementation to match .NET Native and CoreCLR. Fixes #110747
Co-authored-by: Aaron Robinson <[email protected]>
…e/InteropServices/ComWrappers.NativeAot.cs
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
AaronRobinsonMSFT
approved these changes
Dec 25, 2024
4 tasks
jeffschwMSFT
added
Servicing-consider
Issue for next servicing release review
Servicing-approved
Approved for servicing release
and removed
Servicing-consider
Issue for next servicing release review
labels
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110762 to release/9.0-staging
/cc @jkotas
Customer Impact
Intermittent hang, found by Windows Store.
Regression
.NET Native -> .NET 9 regression for UWP/WinUI apps.
Testing
Fix tested on private by Windows Store
Risk
Low. The fix reverts the logic to match .NET Native.
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.