Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 9200] Implement IBaseCodec<T> on CollectionCodec<T> #9209

Conversation

Chris-Eckhardt
Copy link
Contributor

@Chris-Eckhardt Chris-Eckhardt commented Oct 29, 2024

Microsoft Reviewers: Open in CodeFlow

Referenced issues:

@ReubenBond ReubenBond force-pushed the chris-eckhardt/issue-9200/implement-IBaseCodec-in-ICollectionCodec branch from 69aa111 to af16a0c Compare November 2, 2024 01:19
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests & fixed the (already broken) base copier to suit

@ReubenBond ReubenBond force-pushed the chris-eckhardt/issue-9200/implement-IBaseCodec-in-ICollectionCodec branch from af16a0c to 2d8014c Compare November 2, 2024 01:31
@ReubenBond ReubenBond merged commit 909769c into dotnet:main Nov 2, 2024
16 checks passed
@Chris-Eckhardt Chris-Eckhardt deleted the chris-eckhardt/issue-9200/implement-IBaseCodec-in-ICollectionCodec branch November 2, 2024 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants