-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for .NET CancellationTokens #9127
Open
koenbeuk
wants to merge
18
commits into
dotnet:main
Choose a base branch
from
koenbeuk:native-cancellation-tokens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d2334d7.
There is a regression with supporting |
koenbeuk
changed the title
Support for .NET CancellationTokens
[WIP] Support for .NET CancellationTokens
Aug 27, 2024
koenbeuk
changed the title
[WIP] Support for .NET CancellationTokens
Support for .NET CancellationTokens
Aug 27, 2024
ReubenBond
reviewed
Aug 27, 2024
koenbeuk
changed the title
Support for .NET CancellationTokens
[WIP] Support for .NET CancellationTokens
Aug 28, 2024
koenbeuk
changed the title
[WIP] Support for .NET CancellationTokens
Support for .NET CancellationTokens
Sep 2, 2024
This would be super helpful 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for grain methods to be cancelled using a CancellationToken. The implementation is loosely based on the existing GrainCancellationToken support that is already available.
CancellationToken
in a grain interface methodICancellableInvokableGrainExtension.CancelRemoteToken
to mark this token as canceledCancellableInvokableGrainExtension
looks up the grainsICancellationRuntime
component to mark the token as canceledICancellableInvokable
which exposes the method:GetCancellableTokenId
CancellableInvokable
sets a cancellableTokenId asGuid.NewGuid()
InvokeInner
implementation on the invokable can optionally interact with anICancellationRuntime
to track cancellation of this invokable.Once the invokable completes, its CancellationTokenSource obtained through the
ICancellationRuntime
is always CanceledFixes: #8958
Microsoft Reviewers: Open in CodeFlow