Support customization of both document id and partition key for Cosmos DB grain persistence #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s DB grain persistence
ReubenBond
force-pushed
the
fix/cosmos-doc-id-provider
branch
from
774631d to
5c3c5e4
Compare
|
@ReubenBond, Looking ahead at the capabilities for the Microsoft.Extensions.Configuration support you implemented in #9204 should this PR include the ability to configure the type to call from DI for the IDocumentIdProvider of a given provider when configuring via IConfiguration? The wiring might not be there yet but should the configuration value be present on the CosmosGrainStorageOptions class? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only custom partition keys are supported. This is a compilation-breaking change, since it changes the interface used to specify the partition key. The usage of that interface was broken in previous releases, and the fix is straightforward: change your implementation of IPartitionKeyProvider to IDocumentIdProvider. Then, if you do not wish to customize the document id, inject
DefaultDocumentIdProviderand callGetIdto get the document id.Microsoft Reviewers: Open in CodeFlow