Fix all IDE0039 warnings, prefer local functions #8605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pentp
reviewed
Sep 5, 2023
| @@ -513,7 +513,7 @@ private async Task DeactivateActivationsFromCollector(List<ICollectibleGrainCont | |||
| logger.LogInformation((int)ErrorCode.Catalog_ShutdownActivations_1, "DeactivateActivationsFromCollector: total {Count} to promptly Destroy.", list.Count); | |||
| CatalogInstruments.ActiviationShutdownViaCollection(); | |||
|
|
|||
| Action<Task> signalCompletion = task => mtcs.SetOneResult(); | |||
| void signalCompletion(Task task) => mtcs.SetOneResult(); | |||
There was a problem hiding this comment.
This one should be reverted - it's going to cause potentially multiple delegate allocations (one for each list item, instead of one overall).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes part of #8471
Microsoft Reviewers: Open in CodeFlow