Ensure that exceptions thrown from Connection tasks are observed

dotnet · Oct 25, 2023 · 9c70847 · 9c70847
1 parent bf0112d
commit 9c70847
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Orleans.Core/Networking/ConnectionManager.cs b/src/Orleans.Core/Networking/ConnectionManager.cs
@@ -325,7 +325,7 @@ private void StartConnection(SiloAddress address, Connection connection)
             ThreadPool.UnsafeQueueUserWorkItem(state =>
             {
                 var (t, address, connection) = ((ConnectionManager, SiloAddress, Connection))state;
-                _ = t.RunConnectionAsync(address, connection);
+                t.RunConnectionAsync(address, connection).Ignore();
             }, (this, address, connection));
         }
 

diff --git a/src/Orleans.Runtime/Networking/ConnectionListener.cs b/src/Orleans.Runtime/Networking/ConnectionListener.cs
@@ -142,7 +142,7 @@ private void StartConnection(Connection connection)
             ThreadPool.UnsafeQueueUserWorkItem(state =>
             {
                 var (t, connection) = ((ConnectionListener, Connection))state;
-                _ = t.RunConnectionAsync(connection);
+                t.RunConnectionAsync(connection).Ignore();
             }, (this, connection));
         }