Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix for TabbedPage more menu items color. #26876

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root Cause of the issue

  • The TitleColor was used as the foreground color in the DataTemplate applied to the MenuItems. As a result, the color was applied to all items instead of being limited to the items in the NavigationView.

Description of Change

  • I removed the foreground color from the DataTemplate and applied the text color to the menu items in the NavigationView using the NavigationViewItemForeground. This resolved the issue, ensuring that the text color was applied exclusively to the menu items within the NavigationView, without affecting the items in the overflow menu presenter.

Issues Fixed

Fixes #26754

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix

WinUI Reference

  • I have attached an image illustrating the behavior of the WinUI platform when applying the foreground color to a NavigationView item. The color was used exclusively for the items in the NavigationView, consistent with the behavior observed on other MAUI-supported platforms, such as Android, macOS, and iOS.
WinUI-NV (1)

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 31, 2024
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 31, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 2, 2025 14:20
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 2, 2025 14:20
@Redth
Copy link
Member

Redth commented Jan 2, 2025

What does this look like when you change the system theme to dark mode?

@Tamilarasan-Paranthaman
Copy link
Contributor Author

What does this look like when you change the system theme to dark mode?

@Redth, The menu item colors will change to white, similar to the behavior in WinUI, when the system theme is switched to Dark mode. I have attached a video for your reference.

NV-Dark-Mode.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu of TabbedPage's text can be difficult to read
3 participants