Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fix #26868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+80 −1
Open

[iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fix #26868

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b314913
Update CarouselViewController2.cs
kubaflo Dec 30, 2024
a913297
Added a UI test for Matt
kubaflo Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public override UICollectionViewCell GetCell(UICollectionView collectionView, NS
return cell;
}

public override nint GetItemsCount(UICollectionView collectionView, nint section) => LoopItemsSource.LoopCount;
public override nint GetItemsCount(UICollectionView collectionView, nint section) => LoopItemsSource.Loop ? LoopItemsSource.LoopCount : LoopItemsSource.ItemCount;

void InitializeCarouselViewLoopManager()
{
Expand Down
Loading