[Android & iOS] PopToRootAsync for modal pages - improvements #26851
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Hi @pictos what do you think about this? |
kubaflo
force-pushed
the
Shell-PopToRootAsync-doesn't-happen-instantly
branch
from
ab33933 to
09c6260
Compare
kubaflo
changed the title
pictos
approved these changes
Dec 28, 2024
| @@ -28,7 +28,7 @@ internal partial class ModalNavigationManager | |||
| AAnimation? _dismissAnimation; | |||
| bool _platformActivated; | |||
|
|
|||
| readonly Stack<string> _modals = []; | |||
| readonly List<string> _modals = []; | |||
There was a problem hiding this comment.
it looks good to me. Just a heads up, Lists aren't good to remove at start, since it will cause the whole collection to reorganize. So, if in the future, we see some scenario where this can cause a bottleneck, we can change this to other collection.
I doubt it will happen but just in case
|
We are affected by this as well any estimate when this will be merged ? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #26846
Screen.Recording.2024-12-27.at.20.46.44.mov
Screen.Recording.2024-12-27.at.20.45.08.mov