Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScrollToPosition.Center behavior in ScrollView on iOS and MacCatalyst #26825

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Addressed a review concerns

35db49b
Select commit
Loading
Failed to load commit list.
Open

Fix ScrollToPosition.Center behavior in ScrollView on iOS and MacCatalyst #26825

Addressed a review concerns
35db49b
Select commit
Loading
Failed to load commit list.
Azure Pipelines / MAUI-UITests-public failed Jan 2, 2025 in 2h 46m 10s

Build #9.0.30-ci+pr.26825.azdo.131468 had test failures

Details

Tests

  • Failed: 5 (0.16%)
  • Passed: 2,774 (86.53%)
  • Other: 427 (13.32%)
  • Total: 3,206

Annotations

Check failure on line 624 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L624

PowerShell exited with code '1'.

Check failure on line 730 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L730

PowerShell exited with code '1'.

Check failure on line 593 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L593

PowerShell exited with code '1'.

Check failure on line 597 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L597

PowerShell exited with code '1'.

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Bugzilla44461UITests(Mac).Bugzilla44461Test

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Bugzilla44461UITests(Mac).Bugzilla44461Test

  Assert.That(positions.finalPosition.X, Is.LessThanOrEqualTo(1))
  Expected: less than or equal to 1
  But was:  565
Raw output
   at Microsoft.Maui.TestCases.Tests.Issues.Bugzilla44461UITests.Bugzilla44461Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla44461.cs:line 23

1)    at Microsoft.Maui.TestCases.Tests.Issues.Bugzilla44461UITests.Bugzilla44461Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla44461.cs:line 23

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.CollectionViewTabbedPageUITests(Mac).AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.CollectionViewTabbedPageUITests(Mac).AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash

System.TimeoutException : Timed out waiting for element...
Raw output
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2107
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2124
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, IQuery query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 685
   at UITest.Appium.HelperExtensions.WaitForElementTillPageNavigationSettled(IApp app, String elementId, Nullable`1 timeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 1899
   at Microsoft.Maui.TestCases.Tests.Issues.CollectionViewTabbedPageUITests.AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CollectionViewUITests.CollectionViewTabbedPage.cs:line 48
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue25192(Mac).CarouselViewShouldRenderCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue25192(Mac).CarouselViewShouldRenderCorrectly

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: CarouselViewShouldRenderCorrectly.png (1.86% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue25192.CarouselViewShouldRenderCorrectly() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25192.cs:line 20
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue19338(Mac).HeaderAndFooterShouldBeVisible

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue19338(Mac).HeaderAndFooterShouldBeVisible

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: HeaderAndFooterShouldBeVisible.png (2.16% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue19338.HeaderAndFooterShouldBeVisible() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs:line 20
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)