RCLs for Blazor apps that support pages+views #32458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've posted the one question that I have to Artak offline. I'll patch this if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32453
Thanks @ghhv! 🚀 ... Let's see where this goes.
Dan, Artak ... It was several years ago that I had an RCL working in a Blazor Server app with pages/views and components. This PR updates the guidance on using the Support pages and views checkbox for those who do so. We instruct to deselect for pages and views but say that if you do that you also need to make changes to support components and explain those changes.
Also note that @ghhv said on the PU issue that
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>no-oped in a Blazor WASM app, so I didn't remark on it here.Versioning-wise, I'm a bit concerned. It looks like to me based on what I had here from several years ago that the 🧀 moved (at least once) over the years, and I'm not sure how (or even if) to version these revisions. I'll go look at the RCL template over releases and see if I can spot deltas in the project file as a clue for when changes occurred.🏃♂️ UPDATE: I checked all versions of the project template, and the updates on PR apply to all versions. 👍Internal previews