useJWT plugin: allow overriding any JwksClient options #3182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
JwksClient
fromjwks-rsa
has quite a few options which are not made available in theuseJWT
config properties. For my particular use case, I was wanting access togetKeysInterceptor
so that I could intercept jwks loading in my test suite.However, rather than attempt to add support for just one or all of these options, I thought it would be best to allow the user to specify any of these client options by directly referencing its type and merging those props with the props passed to the
JwksClient
constructor.I wasn't clear on whether I could easily add test coverage for this, because it doesn't appear that any of the coverage is directly using a real jwks setup atm.