Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Jn/cycles default #3666

Closed
wants to merge 23 commits into from
Closed

[WIP] Jn/cycles default #3666

wants to merge 23 commits into from

Conversation

johnnovak
Copy link
Member

Description

Describe a summary of your changes clearly and concisely, including motivation and context.
Breaking changes need extra explanation on backward compatibility considerations.

Feel free to include additional details, but please respect the reviewer's time and keep it brief.

Related issues

Related issues can be listed here (remove the section if not applicable.)

Manual testing

Please describe the tests that you ran to verify your changes.

Provide clear instructions so the reviewers can reproduce and verify your results.

Include relevant details for your test configuration, operating system, etc.

Ideally, you would also test your changes with a sanitizer build and confirm no issues were found.

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@johnnovak johnnovak self-assigned this May 11, 2024
@johnnovak johnnovak added the enhancement New feature or enhancement of existing features label May 11, 2024
`CPU_AutoDetermineMode` contained two bit flags, plus there was some
bit-twiddling hackery going on to store the previous value by
bit-shifting it to the left by 2 bits, then back to the right later to
restore the value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant