Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference ~/.config/emacs instead of ~/.emacs.d in getting_started.org #8122

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neilvyas
Copy link

@neilvyas neilvyas commented Oct 23, 2024

Regarding this PRs conformance to contributing standards: this file is in the "do not PR" list, however, the rule in question is marked as "temporary" and dates from 2021, so... I'm assuming it's not really valid, and #6501 was merged after that date.

My commits aren't in conventional commit format, but if the change seems acceptable I can just squash and amend them.

Regarding this PRs quality: I did this from the webUI because I just wanted to change the docs quickly. So, the commit messages, branch name, etc. aren't particularly considered.


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

this seems to be the new style, and is what is present in the readme, so I've updated some of the getting started guide to reflect that.

I have not updated the sections on windows setup and Chemacs setup, since I don't know enough about them to make that change with confidence.

Note that I made this change from the webUI because I'm lazy, so I might have been a bit sloppy.
@neilvyas neilvyas requested a review from a team as a code owner October 23, 2024 05:39
@hlissner hlissner added the do not pr Not accepting PRs like this (check our do-not-PR list) label Oct 23, 2024
@hlissner hlissner marked this pull request as draft November 1, 2024 01:45
@hlissner hlissner added is:docs Pertains to the project's manual, output of help commands, or API documentation was:moved Is, was, or will be addressed elsewhere labels Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not pr Not accepting PRs like this (check our do-not-PR list) is:docs Pertains to the project's manual, output of help commands, or API documentation was:moved Is, was, or will be addressed elsewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants