Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: add :lang flix #7914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CadeMichael
Copy link

@CadeMichael CadeMichael commented Jul 2, 2024

Adding :lang flix module for doom emacs. I took most of the syntax hightlighting from https://github.com/jhckragh/flix-mode and added functions for executing flix commands and installing the flix.jar (the flix executable that is usually project specific and exists in each flix project). I also created a comint mode for interacting with the flix repl and some keybindings. I'm not sure if I laid everything out correctly but I tried to follow these resources. I think I probably butchered the git commit message but I can make changes if needed I'm just a bit confused as to what is needed. Please let me know what I should improve!


  • I searched the issue tracker and this hasn't been PRed before.
  • My commits conform to the git conventions.
    • I believe so but I'm sure I made some mistakes this is my first commit to doom
  • I am blindly checking these off.
  • This a draft PR; I need more time to finish it.
    • I just have this checked because I haven't contributed before and want to confirm I didn't make a glaring mistake.

@CadeMichael CadeMichael requested a review from a team as a code owner July 2, 2024 04:29
@CadeMichael
Copy link
Author

Screenshot 2024-07-01 at 10 30 56 PM Screenshot 2024-07-01 at 10 32 14 PM

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones re:modules Pertains to adding, removing and management of modules labels Jul 5, 2024
@hlissner hlissner marked this pull request as draft July 5, 2024 18:25
@hpfr
Copy link
Contributor

hpfr commented Jul 7, 2024

Instead of making a PR to Doom with a vendored major mode implementation, you might consider forking the archived package and developing from there. Doom modules, particularly for languages, try to limit themselves to setting sane defaults and integrating functionality of upstream packages for a good out-of-the-box experience.

@hlissner hlissner changed the title module: add :lang flix module for the flix programming language module: add :lang flix Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones re:modules Pertains to adding, removing and management of modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants