Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: factorize external executables #7683

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pharcosyle
Copy link
Contributor

I'd like to see external executable dependencies (ripgrep, etc.) better consolidated in the code.

Currently they're scattered all over the place. Ideally there would be a single defvar/defcustom for each that would allow for easy overriding, in particular for Guix/Nix users like me who would like to patch the code in a packaging step so all the various external deps don't have to be installed globally (but it would be useful to everyone else too and it's good practice anyway).

THIS IS A DRAFT PR. Just a start on how this might look and to get feedback.

Some considerations:

  • rg/fd use is inconsistent with respect to remote files
  • perform executable-find at the point of definition or at each point of use (where necessary)?
  • doctor checks for executables depended-on by packages that themselves define a var for the executable should do executable-find on that var, not the raw command as a string

WDYT?

@pharcosyle pharcosyle requested review from a team as code owners February 19, 2024 20:00
@hlissner hlissner marked this pull request as draft February 19, 2024 22:58
@hlissner hlissner added re:env Pertains to the shell environment, operating system or programs installed there is:refactor Code changes with little/no effect on user-facing behavior labels Feb 19, 2024
@pharcosyle pharcosyle force-pushed the factorize-executables branch from 018d40c to 8445a21 Compare July 27, 2024 16:49
@pharcosyle pharcosyle force-pushed the factorize-executables branch from 8445a21 to 9149307 Compare August 8, 2024 04:34
@hlissner hlissner changed the title Factorize external executables refactor: factorize external executables Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:refactor Code changes with little/no effect on user-facing behavior re:env Pertains to the shell environment, operating system or programs installed there
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants