Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Update #34

Closed
wants to merge 63 commits into from
Closed

Dev Update #34

wants to merge 63 commits into from

Conversation

wildone
Copy link

@wildone wildone commented Jun 28, 2016

add dev dotfile profile
add java dotfile profile
add more general tools

@donnemartin
Copy link
Owner

donnemartin commented Jul 1, 2016

Hi @wildone, thanks for taking the time to submit a PR!

I think a previously posted comment on this PR brings up a good point (seems to have been removed by the author):

Some of these are personal choices and not really universal things that are useful to people trying to get a dev setup on their macs

Also, there are currently 63 commits in this single PR. I think one logical change per PR is ideal. I didn't have a chance to look at all 63 commits, perhaps you can submit PRs for each of these?

1f7effe
1b668b1

For 1b668b1 which fixes #32, it looks like you added java7. I don't do much Java development, is this necessary?

-Donne

@donnemartin donnemartin closed this Jul 1, 2016
@audiolion
Copy link

Hey, I removed the previous comment because I felt that the personal choices could be opt-out given the nature of how dev-setup works. Potentially we could have these things set up as default opt-out but the person installing can specify flags or run these extra scripts to opt-in to the more opinionated choices. So I felt it could honestly go either way and I wanted to leave the decision up to you @donnemartin.

I do agree that splitting up this massive PR into smaller PR's that are more narrowly focused and easier to test/rollback/track history on is much better

@wildone
Copy link
Author

wildone commented Jul 7, 2016

Hey guys that for this good work its a great project very comprehensive and helpful

@donnemartin
brew install aircrack-ng #needs java 1.7+

sorry guys did not have much time to play with this, personally I would prefer all of this to be though ansible, but that would have to be a project for the future.

I think all of this is setup is personal and opinionated, hence its good to have a base which you can just modify of purpose. I don't particular use majority of existing tools you had there but its ok its not windows so does not hurt. I just went to add more dev roles to support Devs who probably using linux if they are serious.

@donnemartin
Copy link
Owner

@audiolion @wildone thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants