Make hasher usable
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the only public way to construct a `BloomFilterBuilder`
is by using `BloomFilterBuilder::default()`, which only constructs
a `BloomFilterBuilder<RandomState, CompressedBitmap>`.
Then the `hasher` function takes a `hasher` of type `H`, which can
only ever be called with a `RandomState` as that's the only kind of
`BloomFilterBuilder` you can have.
So you can have a BloomFilterBuilder of any hasher you want, as long as
it's RandomState!
Thus, this test fails to compile:
```
error[E0308]: mismatched types
--> src/bloom.rs:446:21
|
446 | .hasher(BuildHasherDefault::<twox_hash::XxHash64>::default())
| ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `RandomState`, found `BuildHasherDefault<XxHash64>`
| |
| arguments to this method are incorrect
|
= note: expected struct `std::hash::RandomState`
found struct `BuildHasherDefault<XxHash64>`
```
So that it's actually possible to change the hasher :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only public way to construct a
BloomFilterBuilderis by using
BloomFilterBuilder::default(), which only constructsa
BloomFilterBuilder<RandomState, CompressedBitmap>.Then the
hasherfunction takes ahasherof typeH, which canonly ever be called with a
RandomStateas that's the only kind ofBloomFilterBuilderyou can have.So you can have a BloomFilterBuilder of any hasher you want, as long as
it's RandomState!
Thus, this test fails to compile:
To fix this, I changed
hasherinto a constructor that otherwise uses the same values as indefault-- let me know if you'd rather have a different solution :)