Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for unwrapping a privileged db #2528

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jun 4, 2024

No description provided.

@zachmu zachmu marked this pull request as ready for review June 4, 2024 00:28
@zachmu zachmu requested a review from fulghum June 4, 2024 00:35
Copy link

github-actions bot commented Jun 4, 2024

Additional work is required for integration with Dolt.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We didn't have any info schema tests that triggered this one though?

@zachmu
Copy link
Member Author

zachmu commented Jun 4, 2024

LGTM. We didn't have any info schema tests that triggered this one though?

It only got triggered from the driver package, because it doesn't install any auth. Could use much better coverage there.

@zachmu zachmu merged commit d1dca79 into main Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants