Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] Move Json test cases into non-test file so Dolt can depend on them. #2526

Closed
wants to merge 4 commits into from

Conversation

nicktobey
Copy link
Contributor

This moves the test cases for JSON_INSERT into a non-test file, and also allows the caller to provide a function that converts the test's json values into a different representation. This allows us to test the behavior of each implementation of sql.JSONWrapper.

nicktobey added 4 commits May 29, 2024 11:09
…r` implementations that also implement `JSONBytes`, not just `LazyJSONDocument`.
…ave side effects on other uses of the source object.
- JSONBytes and MutableJSON now inherit from `sql.JSONWrapper`
- MutableJSON adds a `Clone() MutableJSON` method, which returns a new JSON value which can be modified without affecting the state of the original.
- New interface: `SearchableJSON` for `JSONWrapper` implementations that support efficient lookups along a path.
@nicktobey nicktobey requested a review from jycor June 3, 2024 18:29
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

@nicktobey nicktobey force-pushed the nicktobey/json-addressmap branch 2 times, most recently from 011931d to f6a384f Compare June 3, 2024 18:32
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

1 similar comment
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

@nicktobey nicktobey force-pushed the nicktobey/json-addressmap branch from e36891e to 2e05df3 Compare June 3, 2024 18:35
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

3 similar comments
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

@nicktobey nicktobey removed the request for review from jycor June 3, 2024 18:55
@nicktobey nicktobey force-pushed the nicktobey/json-addressmap branch from 16df1e4 to 5bd4603 Compare June 3, 2024 18:57
Copy link

github-actions bot commented Jun 3, 2024

Additional work is required for integration with Dolt.
Additional work is required for integration with DoltgreSQL.

@nicktobey nicktobey marked this pull request as draft June 3, 2024 19:12
@nicktobey nicktobey closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant