-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-release-notes] Move Json test cases into non-test file so Dolt can depend on them. #2526
Conversation
…r` implementations that also implement `JSONBytes`, not just `LazyJSONDocument`.
…ave side effects on other uses of the source object.
- JSONBytes and MutableJSON now inherit from `sql.JSONWrapper` - MutableJSON adds a `Clone() MutableJSON` method, which returns a new JSON value which can be modified without affecting the state of the original. - New interface: `SearchableJSON` for `JSONWrapper` implementations that support efficient lookups along a path.
… Clone() method.
Additional work is required for integration with Dolt. |
011931d
to
f6a384f
Compare
Additional work is required for integration with Dolt. |
1 similar comment
Additional work is required for integration with Dolt. |
e36891e
to
2e05df3
Compare
Additional work is required for integration with Dolt. |
3 similar comments
Additional work is required for integration with Dolt. |
Additional work is required for integration with Dolt. |
Additional work is required for integration with Dolt. |
16df1e4
to
5bd4603
Compare
Additional work is required for integration with Dolt. |
This moves the test cases for JSON_INSERT into a non-test file, and also allows the caller to provide a function that converts the test's json values into a different representation. This allows us to test the behavior of each implementation of sql.JSONWrapper.