Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unaligned stores test #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add unaligned stores test #42

wants to merge 3 commits into from

Conversation

JosJuice
Copy link
Member

delroth
delroth reviewed Jul 23, 2021
View reviewed changes
cputest/unaligned_stores.cpp Outdated Show resolved Hide resolved
cputest/unaligned_stores.cpp Outdated

// Get a pointer to a page boundary, with at least 32 bytes available on each side of the boundary
network_printf("Allocating memory...\n");
u8* memory_allocation = new u8[PAGE_SIZE + 32 * 4];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really guarantee whether your buffer ends up in MEM1 or MEM2, which seems relevant for this test. I think libogc has allocation functions which actually do provide these guarantees?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a second commit that does this.

cputest/unaligned_stores.cpp Outdated Show resolved Hide resolved
@JosJuice JosJuice force-pushed the unaligned-stores branch 4 times, most recently from f8a2050 to 7020afb Compare July 26, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JosJuice @delroth