Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workaround for persistent PDO connections #6623

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Revert workaround for persistent PDO connections #6623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Driver/PDO/PDOConnect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
string $password,
array $options,
): PDO {
// see https://github.com/php/php-src/issues/16314
if (PHP_VERSION_ID < 80400 || ($options[PDO::ATTR_PERSISTENT] ?? false) === true) {
if (PHP_VERSION_ID < 80400) {

Check warning on line 21 in src/Driver/PDO/PDOConnect.php

View check run for this annotation

Codecov / codecov/patch

src/Driver/PDO/PDOConnect.php#L21 

Added line #L21 was not covered by tests
return new PDO($dsn, $username, $password, $options);
}

Expand Down
Loading