fix: add missing drop schema when dropping database

doctrine · Oct 27, 2024 · 841f800 · 841f800
1 parent 7a82524
commit 841f800
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 0 deletions.
diff --git a/src/SQL/Builder/DropSchemaObjectsSQLBuilder.php b/src/SQL/Builder/DropSchemaObjectsSQLBuilder.php
@@ -23,6 +23,7 @@ public function buildSQL(Schema $schema): array
         return array_merge(
             $this->buildSequenceStatements($schema->getSequences()),
             $this->buildTableStatements($schema->getTables()),
+            $this->buildNamespaceStatements($schema->getNamespaces()),
         );
     }
 
@@ -51,4 +52,28 @@ private function buildSequenceStatements(array $sequences): array
 
         return $statements;
     }
+
+    /**
+     * @param list<string> $namespaces
+     *
+     * @return list<string>
+     */
+    private function buildNamespaceStatements(array $namespaces): array
+    {
+        if (!$this->platform->supportsSchemas()) {
+            return [];
+        }
+
+        $statements = [];
+
+        foreach ($namespaces as $namespace) {
+            if ($namespace === 'public') {
+                continue;
+            }
+
+            $statements[] = $this->platform->getDropSchemaSQL($namespace);
+        }
+
+        return $statements;
+    }
 }
diff --git a/tests/Functional/Schema/PostgreSQLSchemaManagerTest.php b/tests/Functional/Schema/PostgreSQLSchemaManagerTest.php
@@ -366,6 +366,25 @@ public function testDropWithAutoincrement(): void
         self::assertFalse($schemaManager->tablesExist(['test_autoincrement']));
     }
 
+    public function testDropWithSchema(): void
+    {
+        $this->dropTableIfExists('some_schema.test_namespace');
+
+        $schema = new Schema();
+        $table  = $schema->createTable('some_schema.test_namespace');
+        $table->addColumn('id', Types::INTEGER, ['notnull' => true]);
+        $table->setPrimaryKey(['id']);
+
+        $schemaManager = $this->connection->createSchemaManager();
+        $schemaManager->createSchemaObjects($schema);
+        self::assertSame(['public', 'some_schema'], $schemaManager->listSchemaNames());
+
+        $schema = $schemaManager->introspectSchema();
+        $schemaManager->dropSchemaObjects($schema);
+
+        self::assertSame(['public'], $schemaManager->listSchemaNames());
+    }
+
     public function testListTableDetailsWhenCurrentSchemaNameQuoted(): void
     {
         $this->connection->executeStatement('CREATE SCHEMA "001_test"');