Relax checking of userns_mode to allow supplying e.g. keep-id as config #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using docker-compose in combination with rootless podman containers it is desirable to use the keep-id user namespace mapping. By lifting the restriction to 'host' the userns_mode config can now be used with podman to supply the keep-id or more complex configurations. Signed-off-by: Jonathan Hettwer (bauen1) <[email protected]>
bauen1
force-pushed
the
relax-userns-checks
branch
from
d4f13e4
to
2cebb82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means, that docker-compose can now, like podman-compose containers/podman-compose#166, make use of the user namespaces features of podman.
For example, the following works when using rootless podman in combination with docker-compose: