Automatically add many type hints, with ruff #3222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
force-pushed
the
ruff-types
branch
from
7f8ea9e
to
3861b8e
Compare
If this library is to ship type hints, it is important that those type hints are valid. A type checker (e.g. mypy or pyright) can check that those type hints are valid. This PR is one small step towards that goal. I ran: ``` ruff --extend-select=ANN201,ANN202,ANN204,ANN205,ANN206 --fi x --unsafe-fixes docker ``` and I did not make any manual changes. I chose not to also type other directories (such as `tests`) as that is a decision I'd first like to hear from core maintainers on. Signed-off-by: Adam Dangoor <[email protected]>
adamtheturtle
force-pushed
the
ruff-types
branch
from
3861b8e
to
4716ee3
Compare
|
https://github.com/JelleZijlstra/autotyping, https://github.com/orsinium-labs/infer-types, https://github.com/instagram/MonkeyType could be used to add more types (but they'll require more hand-holding and manual review). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this library is to ship type hints, it is important that those type hints are valid. A type checker (e.g. mypy or pyright) can check that those type hints are valid.
This PR is one small step towards that goal.
I ran:
and I did not make any manual changes.
I chose not to also type other directories (such as
tests) as that is a decision I'd first like to hear from core maintainers on.