Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ accept many messages in DsfrInputGroup #902

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ArnaudTA
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for demo-vue-dsfr ready!

Name Link
🔨 Latest commit 4d8a869
🔍 Latest deploy log https://app.netlify.com/sites/demo-vue-dsfr/deploys/66d1cf7adb79530008eb6bd2
😎 Deploy Preview https://deploy-preview-902--demo-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for docs-vue-dsfr ready!

Name Link
🔨 Latest commit 4d8a869
🔍 Latest deploy log https://app.netlify.com/sites/docs-vue-dsfr/deploys/66d1cf7afc37470008d18e0c
😎 Deploy Preview https://deploy-preview-902--docs-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArnaudTA ArnaudTA force-pushed the feat/input-group-many-messages branch from b270143 to 617a048 Compare August 30, 2024 12:34
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for vue-dsfr ready!

Name Link
🔨 Latest commit 4d8a869
🔍 Latest deploy log https://app.netlify.com/sites/vue-dsfr/deploys/66d1cf7abc3de00008d109ae
😎 Deploy Preview https://deploy-preview-902--vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArnaudTA ArnaudTA force-pushed the feat/input-group-many-messages branch 2 times, most recently from cb7f836 to 11ca9b1 Compare August 30, 2024 13:45
Comment on lines -76 to -85
errorMessage: {
control: 'text',
description:
'Message d’erreur à associer au champ. **Ne fait pas partie du composant. Il appartient à <a href="/?path=/story/composants-champ-de-saisie-champ-avec-message-associ%C3%A9-dsfrinputgroup--champ-en-erreur">DsfrInputGroup</a>**',
},
validMessage: {
control: 'text',
description:
'Message de validation à associer au champ. **Ne fait pas partie du composant. Il appartient à <a href="/?path=/story/composants-champ-de-saisie-champ-avec-message-associ%C3%A9-dsfrinputgroup--champ-valide">DsfrInputGroup</a>**',
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je ne vois pas où c'est utilisé dans la version simple du DsfrInput, je présume que c'est un reliquat qui devrait disparaitre

@laruiss laruiss force-pushed the feat/input-group-many-messages branch from 11ca9b1 to 4d8a869 Compare August 30, 2024 13:56
@laruiss laruiss merged commit 4d2c68c into develop Aug 30, 2024
4 of 5 checks passed
@laruiss laruiss deleted the feat/input-group-many-messages branch August 30, 2024 13:56
Copy link

🎉 This issue has been resolved in version 5.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants