-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SnapLayout Options support for Win11 #345
Conversation
Hello, Sorry for the late response. I like the idea of adding the support for the Win 11 snap layout feature, however, I'd prefer if this was directly integrated into dnSpy code base. I do not want to depend on additional WPF dependencies. If this can be done cleanly and cleanly integrated into dnSpy codebase, I'm all for such a change. Please let me know if you are willing to undergo this change. |
OK, I'll copy the code directly into the dnSpy repository so that it doesn't have to reference the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the code style issues I mentioned in the review, furthermore, would it be possible to isolate the code required for the Snap layouts features and remove the code for other features like rounded corners (already implemented in dnSpy) and others like backdrop, caption styling, etc? preferably the PR should include only the code necessary for the snaplayouts feature. It will make the code much easier to read as it will only contain the necessary logic!
Let me know what you think of these suggestions.
dnSpy/dnSpy/Lib/EleCho.WpfSuite/Utilities/WindowOption.NativeMethods.cs
Outdated
Show resolved
Hide resolved
dnSpy/dnSpy/Lib/EleCho.WpfSuite/Utilities/WindowOption.NativeMethods.cs
Outdated
Show resolved
Hide resolved
Fixed : ) |
If there's anything else you'd like to change, please let me know. |
Thanks! |
Add SnapLayout Options support for Win11