Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlayServerEntityEquipment to 1.16 format #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sentropic
Copy link

Added methods that work with the new Entity Equipment packet format, using ItemSlot-ItemStack pairs
Marked old methods as deprecated
Corrected wrong descriptions in entity related methods

Added methods that work with the new Entity Equipment packet format, using ItemSlot-ItemStack pairs
Marked old methods as deprecated
Copy link

@GoryMoon GoryMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using this and creating a packet from scratch it doesn't set the item slot pair making the client disconnect because of bad packet.
This would need to be added for that to work properly.

Added line updating packet SlotStackPairLists
Added boolean return value to setSlotStackPair and removeSlotStackPair methods
@Sentropic
Copy link
Author

Still expecting a follow-up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants