Use selective imports when importing platform-specific modules (core.sys) #20632
+271
−222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This makes it easier to add support for new platforms to druntime, and maintain platform-specific differences in existing ones. It better reveals the actual dependencies of each module by avoiding implicit public imports.
Progress
This is done for linux and most posix platforms.
Most imports for darwin, solaris and windows are still TODO.
Future work
I'd also like to attempt this with
core.stdc
. That would (in combination with this pr) open up the possibility for developers working with aFreestanding
platform to get parts of druntime to work without needing an entire supported libc, just specific functions.Also, contrary to what druntime assumes, not every platform has concepts like a filesystem, stdio, processes... This could help in determining what modules have those features as hard dependencies, and what modules could also work without them on such platforms.