Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Symfony4 support #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jjmonagas
Copy link

Added dependencies for Symfony4 in composer.json
Including new PHP 7.1 travis test for Sf4.0 beta

#SymfonyConHackday2017

Jose Juan Monagas Santana added 2 commits November 18, 2017 15:16
Including new PHP 7.1 travis test for Sf4.0 beta
PHPUnit TestCase getMock() method deprecated since Release 5.4.0 - Replaced by createMock()
Constant PHPUnit_Framework_Error_Deprecated doesn’t exists - Commented

IMPORTANT: Build still FAILS because HTTP DIGEST authentication system has been removed. One solution can be remove ‘validateDigest’ method from Provider Class (NonceExpiredException has been removed in Sf4.0)
@wiistriker
Copy link

can this be merged?

@jjmonagas
Copy link
Author

@wiistriker It has been a long time since I created this PR. Feel free to create a new branch and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants