Add missing attributes, recipes for FPM & Apache2, and comment out xdebug.remote_log
when blank.
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with this cookbook I noticed
notifies :restart, resources("service[apache2]"), :delayed
was causing my provisioning to fail (I'm an Nginx + PHP-FPM user). I removed that line from the default recipe and added two additional recipes:xdebug::apache2
andxdebug::fpm
. The two new recipes don't do much right now other than runxdebug::default
and restart relevant services. This should make the cookbook independent of a user's web server.In addition, I added a couple missing attributes and conditionally commented out
xdebug.remote_log
when it is blank. My editor also removed a bit of trailing whitespace (hope it isn't too annoying to read the diffs).And finally, I added quotes around
xdebug.file_link_format
so PHP doesn't freak out when it encounters an=
sign in the link format (e.g.txmt://open?url=file://%f&line=%l
).