Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes, recipes for FPM & Apache2, and comment out xdebug.remote_log when blank. #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gevans
Copy link

@gevans gevans commented Feb 21, 2012

While playing with this cookbook I noticed notifies :restart, resources("service[apache2]"), :delayed was causing my provisioning to fail (I'm an Nginx + PHP-FPM user). I removed that line from the default recipe and added two additional recipes: xdebug::apache2 and xdebug::fpm. The two new recipes don't do much right now other than run xdebug::default and restart relevant services. This should make the cookbook independent of a user's web server.

In addition, I added a couple missing attributes and conditionally commented out xdebug.remote_log when it is blank. My editor also removed a bit of trailing whitespace (hope it isn't too annoying to read the diffs).

And finally, I added quotes around xdebug.file_link_format so PHP doesn't freak out when it encounters an = sign in the link format (e.g. txmt://open?url=file://%f&line=%l).

@ghost ghost assigned dkingofpa May 24, 2012
@gevans
Copy link
Author

gevans commented Apr 10, 2013

@dkingofpa Should I close this?

@djoos
Copy link
Member

djoos commented Jan 27, 2014

Hi @gevans,

I'm the new maintainer of the xdebug cookbook and I hope to get back to you on this PR within the next few weeks...

Kind regards,
David

@gevans
Copy link
Author

gevans commented Jan 28, 2014

@djoos No worries. This is a very old pull request. :P

On a side note, I apologize for the noise in the diff. It would seem my editor had removed trailing whitespace which adds a bit of confusion as to exactly what was changed.

@djoos djoos self-assigned this Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants