Added index on aggregator_feeditem (date_modified DESC)
#1517
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasmcnulty
force-pushed
the
aggregator_index
branch
from
45975fc
to
60eff5e
Compare
bmispelon
requested changes
Apr 10, 2024
There was a problem hiding this comment.
This looks great, especially if the speedups you observed locally hold up in production also.
One nitpick I had would be to change the name of the migration file to something slightly more readable. Maybe 0005_feeditem_add_index_date_modified.py. What do you think?
tobiasmcnulty
force-pushed
the
aggregator_index
branch
from
60eff5e
to
526649e
Compare
|
Thanks for the review!
That is a favorite nitpick of mine, I am surprised I let it slip, lol. Updated! |
bmispelon
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pages early in the aggregator/community feeds, there is a tremendous speedup when an index is added on
aggregator_feeditem (date_modified DESC)(i.e., in the order in which the FeedItems are returned). In my tests, it reduced the query time from ~170ms to ~6ms. The change will help reduce load on the database server and free up uWSGI processes for other requests.