Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package missing management folder(#508) #509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1One0
Copy link

@1One0 1One0 commented Apr 11, 2024

In setup.cfg

packages = find: was changed to

packages =
    daphne    
    twisted.plugins

When manually list packages, should enumerate all the packages

packages =
    daphne
    daphne.management
    twisted.plugins

@carltongibson
Copy link
Member

carltongibson commented Apr 11, 2024

Thanks for this @1One0

commands is a package too no?

I was wondering if we could fix the find: by setting package_dirs 🤔
(Looking at the daphne-4.1.x-py3-none-any.whl/daphne-4.1.x.dist-info/top_level.txt in the wheel is what differs from 4.0)

@carltongibson
Copy link
Member

Screenshot 2024-04-11 at 11 32 32

Built wheel missing the commands package. We could add that as well, but I'd rather fix the find:.

@1One0
Copy link
Author

1One0 commented Apr 11, 2024

What about add a extra daphne.management.commands?

Or move the dir /daphne/twisted/plugin to /twisted/plugin then can easily use:

package_dir =
packages =find:

The problem is hard to change top-level with setup.cfg, it will be easier when use setup.py.

@carltongibson
Copy link
Member

Another take on this in #510.

If you checkout the branch you can python -m build and then inspect the wheel to see both the twisted plugin and the Daphne subpackages picked up.

@1One0
Copy link
Author

1One0 commented Apr 11, 2024

oh i see, and this problem is exist earlier, it happend when changefind:
I will try to find a way to fix that...

@carltongibson
Copy link
Member

@1One0 I think #510 is correct no? Can you test to confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants