Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #127 (wrong TAX when VAT ID doesn't have country code) #128

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

PetrDlouhy
Copy link
Collaborator

@PetrDlouhy PetrDlouhy commented Feb 24, 2021

Fix #127

  • validate also that country code corresponds with country

@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #128 (6151f36) into master (b60e074) will decrease coverage by 0.17%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   79.85%   79.67%   -0.18%     
==========================================
  Files          40       40              
  Lines        2169     2175       +6     
==========================================
+ Hits         1732     1733       +1     
- Misses        437      442       +5     
Impacted Files Coverage Δ
plans/views.py 35.62% <0.00%> (ø)
plans/models.py 88.64% <10.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e074...6151f36. Read the comment docs.

@Alir3z4
Copy link
Collaborator

Alir3z4 commented May 5, 2021

Would be great to have tests for this.

PetrDlouhy added a commit to PetrDlouhy/django-plans that referenced this pull request Oct 6, 2021
@PetrDlouhy
Copy link
Collaborator Author

@Alir3z4 I have finally get some time to write the tests. But I am not seeing the CI being executed.

@Alir3z4
Copy link
Collaborator

Alir3z4 commented Oct 9, 2021

@Alir3z4 I have finally get some time to write the tests. But I am not seeing the CI being executed.

@PetrDlouhy thanks for making the tests.

After merging your other awesome pull requests, this one started having conflicts. Please resolved that.

Regarding CI, due to #133 there won't be any CI.
I'm not sure if I can attempt making that happen for some time.

If you can make that, that would be great then I'll take a stab at #134

@Alir3z4 Alir3z4 merged commit 4b72284 into django-getpaid:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAX is applied if the user fills in VAT ID without country code
3 participants