Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Github Actions #133

Closed
Alir3z4 opened this issue Oct 9, 2021 · 3 comments · Fixed by #135
Closed

Migrating to Github Actions #133

Alir3z4 opened this issue Oct 9, 2021 · 3 comments · Fixed by #135

Comments

@Alir3z4
Copy link
Collaborator

Alir3z4 commented Oct 9, 2021

Travic CI doesn't work anymore.
If you visit https://travis-ci.org/cypreess/django-plans, you would see a notice saying:

Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.

They no longer have a free CI for open source projects.

Out of all the alternatives, would be sane to just use Github Actions:
Until then, no CI jobs or code coverage would happen on the new code.

@Alir3z4
Copy link
Collaborator Author

Alir3z4 commented Oct 9, 2021

Once this is done, I can start working on #134

Alir3z4 added a commit that referenced this issue Oct 11, 2021
Fixes #133: Add main.yml for GitHub actions; fix tests
@Alir3z4 Alir3z4 reopened this Oct 12, 2021
@Alir3z4
Copy link
Collaborator Author

Alir3z4 commented Oct 12, 2021

Great work @PetrDlouhy on this.

One problem I noticed. Codecov doesn't pick up the coverage.
Have a look at https://github.com/django-getpaid/django-plans/runs/3866850627

    GitHub Actions CI Detected
    Fixing merge commit SHA
==> Preparing upload
==> Processing gcov (disable by -X gcov)
==> Collecting reports
Error: No coverage report found
Tip: See all example repositories: https://github.com/codecov?query=example

Probably because the codecov runs in another step and coverage report doesn't exists there?
I guess we might be able to fix this to include the coverage within the tests step?

@Alir3z4
Copy link
Collaborator Author

Alir3z4 commented Oct 12, 2021

The codecov issue has been fixed via #142

@Alir3z4 Alir3z4 closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant