Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Include hidden file in artifact build #260

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mrbazzan
Copy link
Contributor

@mrbazzan mrbazzan commented Jan 16, 2025

Description

Quick test to see if adding include-hidden-file works

Summary by Sourcery

CI:

  • Upload hidden coverage files as artifacts.

Copy link

sourcery-ai bot commented Jan 16, 2025

Reviewer's Guide by Sourcery

This pull request adds the include-hidden-file option to the actions/upload-artifact@v4 step in the test workflow. This change ensures that hidden files, such as .coverage.* files, are included in the coverage data artifact. The change was implemented by adding include-hidden-file: true to the with block of the upload-artifact step.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Include hidden files in the coverage data artifact
  • Added include-hidden-file: true to the actions/upload-artifact@v4 step
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrbazzan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context about why this change is needed and confirm you've tested that it properly includes the hidden coverage files in the artifacts. The PR shouldn't be used as the test itself.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! Good work!

@mrbazzan
Copy link
Contributor Author

NICE! Good work!

Thanks.
Life would have been easier if I found this earlier.

@fsbraun
Copy link
Member

fsbraun commented Jan 16, 2025

@mrbazzan Yeah, I did not know about this! Can you check which repos are affected?

@fsbraun fsbraun merged commit 75d738c into django-cms:master Jan 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants