-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Include hidden file in artifact build #260
Conversation
Reviewer's Guide by SourceryThis pull request adds the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrbazzan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more context about why this change is needed and confirm you've tested that it properly includes the hidden coverage files in the artifacts. The PR shouldn't be used as the test itself.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! Good work!
Thanks. |
@mrbazzan Yeah, I did not know about this! Can you check which repos are affected? |
Description
Quick test to see if adding
include-hidden-file
worksSummary by Sourcery
CI: