Added DjStripeHTTPClient to handle all Stripe API calls. #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav13081994
changed the title
arnav13081994
force-pushed
the
feature/add_http_client
branch
5 times, most recently
from
54f4276
to
3622742
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arnav13081994
force-pushed
the
feature/add_http_client
branch
from
3622742
to
2e0c7ec
Compare
arnav13081994
force-pushed
the
feature/add_http_client
branch
from
2e0c7ec
to
69e7ddd
Compare
arnav13081994
force-pushed
the
feature/add_http_client
branch
4 times, most recently
from
91d768a
to
67332d8
Compare
arnav13081994
changed the title
arnav13081994
changed the title
… Model This was done because one can create multiple independent update requests for the exact same Stripe object.
The _api_update() method now does the following: 1) Generates a new Idempotency Key object if not given one using the Stripe object's ID that is being updated. 2) Uses the Idempotency key (from 1)) to make the Stripe API call. 3) Updates the metadata of the Stripe object with the idempotency_key key if the Stripe object supports the metadata key.
This was done in order for the STRIPE_TEST_SECRET_KEY env var to be passed from tox to pytest.
This was done in order to get around RateLimit and other related errors.
This was done because tests would fail due to low coverage of tests using the api. This is a temp fix until more tests can be added.
arnav13081994
force-pushed
the
feature/add_http_client
branch
2 times, most recently
from
382696b
to
2cca5c7
Compare
…nning tests This was done because in some errors Stripe may ask us not to retry.
arnav13081994
force-pushed
the
feature/add_http_client
branch
from
2cca5c7
to
1e3c4d9
Compare
arnav13081994
changed the title
|
My two cents: I'm not fond of adding an additional layer of abstraction to the Stripe Python client. These are already features that exist in that client, and adding this layer of abstraction absolutely will introduce confusion, as well as increasing maintenance costs. Additionally, adding test flags is a code smell. If you need flags to test the code, then the code should be refactored to be more appropriately testable. If having default retries/rate limit handling is desired, a more appropriate approach would be to configure a central |
jleclanche
force-pushed
the
master
branch
5 times, most recently
from
15e04c3
to
8727894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1909 and PR #1910 need to be merged before this PR can be merged.
This PR adds support for
DjStripeHTTPClientthat provides out of the box the following capabilities:rate_limiterrorslock_timeouterrorsIdempotencykeys as the case may be.