Updated dependencies #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, when you want to use, for example, your Apple Silicon Mac to build for both Mac (universal) & Windows - you will need to stick with Electron 26.x (at least for now). It's mentioned in this issue: alex8088/electron-vite#315 |
|
Great to know! I had no idea that issue existed - I've only been building for arm64 at this moment. I've rolled back electron to the latest 26.x and checked to make sure that electron-builder was still compatible as well. An update to LMK if you see any other dependency related issues, and I'll be happy to fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's fully working dependencies with electron 28.2.5. Also updated electron-builder and vite-electron and vite.
In renderer, I updated svelte, svelteKit, vite added the new
vitePreprocessplugin for svelteKit. Had to adjust the main+layout.svelteto add a slot.main/index.tsgot prettified.main/lib/utils.tsupdated -event.isTrustedno longer existed, so I removed the method oneventrenderer/svelte.config.jsupdated to include the new vitePreprocess plugin.Let me know if you have any questions about anything else or notice any errors!