Improve unit tests. #270
Open
Improve unit tests. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Jul 13, 2020
| 'kerberos:sys_platform=="win32"': ['winkerberos>=0.5.0'], | ||
| 'kerberos:sys_platform!="win32"': ['pykerberos>=1.2.1,<2.0.0'] | ||
| }, | ||
| install_requires=req_deps_list, |
There was a problem hiding this comment.
don't do this, tox can use the extras and install_requires, just make sure to set `skipsdist = False
There was a problem hiding this comment.
then you can do:
[testenv]
extras = test,credssp,kerberos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things I wanted to do in this PR:
requests_mocklibraryThe goal of this to be more comfortable with the winrm interaction in the long run.