Ignore non-input maps after map merge #3507
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
priority/medium
jelovirt
force-pushed
the
feature/prune-maps
branch
from
dc3a9e2
to
bf8cfc9
Compare
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
|
Due to conref and conrefpush between maps, this is somewhat problematic. The non-merged cannot be ignored immediately. The keyref, conref, and conrefpush stages need to be processed first, only then non-merged maps can be ignored or removed. |
jelovirt
force-pushed
the
feature/prune-maps
branch
from
bf8cfc9
to
b9cf752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After map merge, ignore non-input maps in processing.
Motivation and Context
After map merge only the input maps are used in processing. Submaps are no longer used for anything. This reduces the number of files that need to be processed.
Preprocess2 has already used this approach in most places, adding this to preprocess makes sense for consistency and performance improvement.
Documentation and Compatibility
This can be backwards incompatible change if custom plug-ins use the submaps after map merge. We have never explicitly forbidden this, but it has never been something that makes sense for plug-ins to do.