-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple input files #3286
base: develop
Are you sure you want to change the base?
Conversation
da464ee
to
860505a
Compare
@robander However, because Ant doesn't have support for array types, do we want to use properties to be begin with for So, how to handle both URIs and file paths in the same property, because there is no obvious separator character. For paths we can just use the system separators Would it be OK if we defined Or have |
ebbd3f3
to
4f7e456
Compare
@jelovirt Thinking about how I'm most likely to use this in our larger environment, I think URIs would be OK as long as it can take the absolute path: I think over time more and more people interact with the command through editors or build scripts, which should be able to hide or translate the values appropriately. Basically, adding that layer ahead of the build to translate paths in a more friendly way. I'm also thinking about this (for now) as a more complex usage, where it seems more acceptable to enforce stricter rules about the input - maybe others would see it differently? |
9756dc9
to
af1d1dc
Compare
af1d1dc
to
c7a2c56
Compare
This could resolve #1697 |
@@ -326,7 +327,9 @@ public Arguments processArgs(final String[] arguments) { | |||
targets.addElement(arg); | |||
} | |||
} | |||
if (!inputs.isEmpty()) { | |||
if (inputs.size() > 1) { | |||
definedProps.put("args.inputs", String.join(" ", inputs)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to cause issues with inputs that have spaces in the file name or path? Or do those get normalized to %20
before we reach this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to the client to pass valid URIs. So if the end user user inputs an invalid URI (a URI with a space) to the client, the client will need to convert it to a valid URI (by escaping the space with a %20
) when setting args.inputs
property.
c7a2c56
to
a3078f9
Compare
a3078f9
to
62b3229
Compare
Dropping from 3.4 release due to lack of interest. Maybe in 4.0 |
e807467
to
e936196
Compare
c886ade
to
836cd1f
Compare
90ad1d3
to
98031c8
Compare
98031c8
to
208450d
Compare
208450d
to
5f9a9a0
Compare
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
Signed-off-by: Jarno Elovirta <[email protected]>
5f9a9a0
to
5dc3499
Compare
Add support for multiple input files per DITA-OT process.
Multiple input files should work the same was as a single input file with additional resource files, except all resource files are treated as
processing-role="normal"
.Interface changes
In the CLI, add support for multiple
--input
arguments.For project files, add support for multiple input fields.
Add
args.inputs
Ant property: