A bunch of random improvements #58
Conversation
| @@ -115,12 +117,13 @@ await GetPackageDependencies( | |||
|
|
|||
| foreach (var path in libraries) | |||
| { | |||
| var assembly = Assembly.LoadFrom(path); | |||
| if (context.TryAddReferenceAssembly(assembly)) | |||
| var asm = Assembly.LoadFile(path); | |||
There was a problem hiding this comment.
| var asm = Assembly.LoadFile(path); | |
| var assembly = Assembly.LoadFile(path); |
| public void ResetButton() | ||
| { | ||
| System.Environment.Exit(0); | ||
| } | ||
|
|
||
| public void PowerButton() | ||
| { | ||
| System.Environment.Exit(1); | ||
| } |
There was a problem hiding this comment.
I don't think there's mileage in getting rid of this. If there are other consumers of the REPL, it's likely that they may want this API to remain for now.
There was a problem hiding this comment.
Are there any other users? In any case after removal of BasicEnvironment you can call the method that these wrapped anyway, but I have no strong opinion either way
| public static ConsoleLikeStringWriter Console { get; internal set; } | ||
| public static BasicEnvironment Environment { get; internal set; } |
There was a problem hiding this comment.
What is the motivation behind removing the environment facade?
There was a problem hiding this comment.
It's kinda just dead code? I believe it originates from where there was an idea that the repl should be "secure", and if you remove the analyzer that blacklisted the real System.Environment like I also did here, you get almost the same behavior. The one big exception is that it doesn't stop you from reading/writing environment variables anymore, but that was easily bypassed with reflection or Cmd("env"); anyway.
There was a problem hiding this comment.
I think these should be split into separate files at this point.
There was a problem hiding this comment.
I can do that, was just leaving it as I found it originally
No description provided.