Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: children of imageFile missing on build #4

Merged
merged 3 commits into from Nov 2, 2022
Merged

fix: children of imageFile missing on build #4

merged 3 commits into from Nov 2, 2022

Conversation

buttreygoodness
Copy link

No description provided.

@buttreygoodness
Copy link
Author

Fix for bug #1 . Children of imageFile in graphql queries were sometimes missing.
Pre @chmielulu suggestion, refactored the image node creation to sourceNodes hook and reference those in the fileResolver.

rijkvanzanten
rijkvanzanten requested changes Sep 13, 2022
View reviewed changes
gatsby-node.js Outdated Show resolved Hide resolved
@rijkvanzanten rijkvanzanten added the bug Something isn't working label Sep 13, 2022
@KonstantinSolv
Copy link

Hi guys, any timeline when this could be merged?

@rijkvanzanten
Copy link
Member

Hi guys, any timeline when this could be merged?

Whenever it's ready. As of right now, there's an unresolved conversation which prevents this from being merged. Wanna take over the PR @KonstantinKaminski?

@jeffloop
Reformatting tabs/apaces
a820457 
Adding editorconfig, .eslintrc.js and .prettierrc.js from main directus repo.
@jeffloop
Changed spaces
eb6f66c 
Changed spaces before function argument parens
@buttreygoodness
Copy link
Author

My apologies for the dealy.... Made changes to the document formatting. This change is untested but it works with my directus installation which contains a huge amount of images.

@rijkvanzanten
Copy link
Member

@KonstantinKaminski Mind giving this PR a review to see if the solution is working for you? I'm no gatsby user myself 🙂

freekrai
freekrai approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@freekrai freekrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rijkvanzanten rijkvanzanten merged commit ff89be3 into directus:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekrai freekrai freekrai approved these changes

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@freekrai freekrai

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@buttreygoodness @KonstantinSolv @rijkvanzanten @freekrai @jeffloop